lkml.org 
[lkml]   [2020]   [Apr]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Subject[PATCH v3 0/5] support setting sysctl parameters from kernel command line
Date
This series adds support for something that seems like many people always
wanted but nobody added it yet, so here's the ability to set sysctl parameters
via kernel command line options in the form of sysctl.vm.something=1

The important part is Patch 1. The second, not so important part is an attempt
to clean up legacy one-off parameters that do the same thing as a sysctl.
I don't want to remove them completely for compatibility reasons, but with
generic sysctl support the idea is to remove the one-off param handlers and
treat the parameters as aliases for the sysctl variants.

I have identified several parameters that mention sysctl counterparts in
Documentation/admin-guide/kernel-parameters.txt but there might be more. The
conversion also has varying level of success:

- numa_zonelist_order is converted in Patch 2 together with adding the
necessary infrastructure. It's easy as it doesn't really do anything but warn
on deprecated value these days.
- hung_task_panic is converted in Patch 3, but there's a downside that now it
only accepts 0 and 1, while previously it was any integer value
- nmi_watchdog maps to two sysctls nmi_watchdog and hardlockup_panic, so
there's no straighforward conversion possible
- traceoff_on_warning is a flag without value and it would be required to
handle that somehow in the conversion infractructure, which seems pointless
for a single flag

Vlastimil Babka (3):
kernel/sysctl: support setting sysctl parameters from kernel command
line
kernel/sysctl: support handling command line aliases
kernel/hung_task convert hung_task_panic boot parameter to sysctl

Changes since v2:
- rebase to 5.7-rc3
- add acks
- add a testcase to tools/testing/selftests/sysctl/sysctl.sh - this adds a new
sysctl parameter ../boot_int in lib/test_sysctl and expects the tester to
pass the respective boot parameter in any feasible way (including bootconfig)
the testcase checks /proc/cmdline to distinguish real failure from the lack of
parameter. That allows us to test this without introducing further new
functionality (patches 4+5).

Vlastimil Babka (5):
kernel/sysctl: support setting sysctl parameters from kernel command
line
kernel/sysctl: support handling command line aliases
kernel/hung_task convert hung_task_panic boot parameter to sysctl
tools/testing/selftests/sysctl/sysctl.sh: support CONFIG_TEST_SYSCTL=y
lib/test_sysctl: support testing of sysctl. boot parameter

.../admin-guide/kernel-parameters.txt | 11 +-
fs/proc/proc_sysctl.c | 142 ++++++++++++++++++
include/linux/sysctl.h | 4 +
init/main.c | 2 +
kernel/hung_task.c | 10 --
lib/test_sysctl.c | 13 ++
mm/page_alloc.c | 9 --
tools/testing/selftests/sysctl/sysctl.sh | 42 +++++-
8 files changed, 210 insertions(+), 23 deletions(-)

--
2.26.0

\
 
 \ /
  Last update: 2020-04-27 20:05    [W:0.126 / U:0.824 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site