Messages in this thread | | | Date | Mon, 27 Apr 2020 10:01:59 -0700 | From | Sami Tolvanen <> | Subject | Re: [PATCH v13 01/12] add support for Clang's Shadow Call Stack (SCS) |
| |
On Mon, Apr 27, 2020 at 06:48:49PM +0200, Miguel Ojeda wrote: > On Mon, Apr 27, 2020 at 6:00 PM Sami Tolvanen <samitolvanen@google.com> wrote: > > > > diff --git a/include/linux/compiler-clang.h b/include/linux/compiler-clang.h > > index 333a6695a918..18fc4d29ef27 100644 > > --- a/include/linux/compiler-clang.h > > +++ b/include/linux/compiler-clang.h > > @@ -42,3 +42,9 @@ > > * compilers, like ICC. > > */ > > #define barrier() __asm__ __volatile__("" : : : "memory") > > + > > +#if __has_feature(shadow_call_stack) > > +# define __noscs __attribute__((__no_sanitize__("shadow-call-stack"))) > > +#else > > +# define __noscs > > +#endif > > Can we remove the `#else` branch? compiler_types.h [*] has to care > anyway about that case for other compilers anyway, no?
Yes, it's unnecessary. I'll remove this in the next version. Thanks!
Sami
| |