lkml.org 
[lkml]   [2020]   [Apr]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 06/23] sched,psci: Convert to sched_set_fifo*()
Date

On 27/04/20 17:35, Qais Yousef wrote:
>> drv = cpuidle_get_cpu_driver(dev);
>> @@ -349,11 +347,6 @@ static int suspend_test_thread(void *arg
>> if (atomic_dec_return_relaxed(&nb_active_threads) == 0)
>> complete(&suspend_threads_done);
>>
>> - /* Give up on RT scheduling and wait for termination. */
>> - sched_priority.sched_priority = 0;
>> - if (sched_setscheduler_nocheck(current, SCHED_NORMAL, &sched_priority))
>> - pr_warn("Failed to set suspend thread scheduler on CPU %d\n",
>> - cpu);
>
> No need for sched_set_normal() here before the busy loop?
>

Given the tasks become TASK_INTERRUPTIBLE, and the only extra thing they'll
do is exit (barring the parking weirdness), changing them back to CFS
seems superfluous.

> Thanks

\
 
 \ /
  Last update: 2020-04-27 18:59    [W:0.094 / U:4.404 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site