Messages in this thread | | | From | Valentin Schneider <> | Subject | Re: [PATCH 06/23] sched,psci: Convert to sched_set_fifo*() | Date | Mon, 27 Apr 2020 17:58:15 +0100 |
| |
On 27/04/20 17:35, Qais Yousef wrote: >> drv = cpuidle_get_cpu_driver(dev); >> @@ -349,11 +347,6 @@ static int suspend_test_thread(void *arg >> if (atomic_dec_return_relaxed(&nb_active_threads) == 0) >> complete(&suspend_threads_done); >> >> - /* Give up on RT scheduling and wait for termination. */ >> - sched_priority.sched_priority = 0; >> - if (sched_setscheduler_nocheck(current, SCHED_NORMAL, &sched_priority)) >> - pr_warn("Failed to set suspend thread scheduler on CPU %d\n", >> - cpu); > > No need for sched_set_normal() here before the busy loop? >
Given the tasks become TASK_INTERRUPTIBLE, and the only extra thing they'll do is exit (barring the parking weirdness), changing them back to CFS seems superfluous.
> Thanks
| |