lkml.org 
[lkml]   [2020]   [Apr]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2] drivers: staging: rts5208: rtsx.c fix Unbalanced braces around else-if statements
On Mon, Apr 27, 2020 at 04:24:42PM +0100, John Oldman wrote:
> Make a better job of fixing coding style issues, this time fixing
> all blocks as per Joe Perches' comment.
>
> Signed-off-by: John Oldman <john.oldman@polehill.co.uk>
> ---
> drivers/staging/rts5208/rtsx.c | 14 +++++---------
> 1 file changed, 5 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/staging/rts5208/rtsx.c b/drivers/staging/rts5208/rtsx.c
> index ca836ca2ee81..e16a7b9c3203 100644
> --- a/drivers/staging/rts5208/rtsx.c
> +++ b/drivers/staging/rts5208/rtsx.c
> @@ -402,19 +402,15 @@ static int rtsx_control_thread(void *__dev)
> if (chip->srb->sc_data_direction == DMA_BIDIRECTIONAL) {
> dev_err(&dev->pci->dev, "UNKNOWN data direction\n");
> chip->srb->result = DID_ERROR << 16;
> - }
> -
> - /* reject if target != 0 or if LUN is higher than
> - * the maximum known LUN
> - */
> - else if (chip->srb->device->id) {
> + } else if (chip->srb->device->id) {
> + /* reject if target != 0 or if LUN is higher than
> + * the maximum known LUN
> + */
> dev_err(&dev->pci->dev, "Bad target number (%d:%d)\n",
> chip->srb->device->id,
> (u8)chip->srb->device->lun);
> chip->srb->result = DID_BAD_TARGET << 16;
> - }
> -
> - else if (chip->srb->device->lun > chip->max_lun) {
> + } else if (chip->srb->device->lun > chip->max_lun) {
> dev_err(&dev->pci->dev, "Bad LUN (%d:%d)\n",
> chip->srb->device->id,
> (u8)chip->srb->device->lun);
> --
> 2.17.1

Why is this not just one patch?

\
 
 \ /
  Last update: 2020-04-27 18:05    [W:0.043 / U:10.148 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site