lkml.org 
[lkml]   [2020]   [Apr]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v3 1/6] bus: mhi: core: Make sure to powerdown if mhi_sync_power_up fails
    Date
    Powerdown is necessary if mhi_sync_power_up fails due to a timeout, to
    clean up the resources. Otherwise a BUG could be triggered when
    attempting to clean up MSIs because the IRQ is still active from a
    request_irq().

    Signed-off-by: Jeffrey Hugo <jhugo@codeaurora.org>
    ---
    drivers/bus/mhi/core/pm.c | 6 +++++-
    1 file changed, 5 insertions(+), 1 deletion(-)

    diff --git a/drivers/bus/mhi/core/pm.c b/drivers/bus/mhi/core/pm.c
    index 52690cb..dc83d65 100644
    --- a/drivers/bus/mhi/core/pm.c
    +++ b/drivers/bus/mhi/core/pm.c
    @@ -902,7 +902,11 @@ int mhi_sync_power_up(struct mhi_controller *mhi_cntrl)
    MHI_PM_IN_ERROR_STATE(mhi_cntrl->pm_state),
    msecs_to_jiffies(mhi_cntrl->timeout_ms));

    - return (MHI_IN_MISSION_MODE(mhi_cntrl->ee)) ? 0 : -EIO;
    + ret = (MHI_IN_MISSION_MODE(mhi_cntrl->ee)) ? 0 : -ETIMEDOUT;
    + if (ret)
    + mhi_power_down(mhi_cntrl, false);
    +
    + return ret;
    }
    EXPORT_SYMBOL(mhi_sync_power_up);

    --
    Qualcomm Technologies, Inc. is a member of the
    Code Aurora Forum, a Linux Foundation Collaborative Project.
    \
     
     \ /
      Last update: 2020-04-27 17:59    [W:4.047 / U:0.216 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site