lkml.org 
[lkml]   [2020]   [Apr]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] rtc: Do not sync CMOS clock when CONFIG_RTC_SYSTOHC is not set
On Mon, Apr 27, 2020 at 12:30 PM Thomas Gleixner <tglx@linutronix.de> wrote:
>
> Leonid Bloch <lb.workbox@gmail.com> writes:
> > According to documentation in 'drivers/rtc/Kconfig', if
> > 'CONFIG_RTC_SYSTOHC' is set, then:
> >
> > '''
> > The system time (wall clock) will be stored in the RTC specified by
> > RTC_HCTOSYS_DEVICE approximately every 11 minutes if userspace reports
> > synchronized NTP status.
> > '''
> >
> > However in reality, even if 'CONFIG_RTC_SYSTOHC' is not set, the RTC
> > is still sometimes synced with the system time: at least when the RTC
> > driver is 'rtc_cmos', in certain situations. This commit prevents
> > that.
>
> But in reality sync_cmos_clock() depends on CONFIG_GENERIC_CMOS_UPDATE
> and has nothing to do with CONFIG_RTC_SYSTOHC.
>
> That's a historical leftover from the days where RTCs were strictly a
> platform/architecture specific issue.
>
> Your change would break all architectures which still depend on that.

Thanks for your clarification, Thomas!

Then maybe it's worth to reword the help string in
drivers/rtc/Kconfig? Because one can unset 'CONFIG_RTC_SYSTOHC' and
expect that the RTC clock will not be updated by NTP syncs, while in
reality it will be, unless 'CONFIG_GENERIC_CMOS_UPDATE' is unset, and
it is selected automatically by X86.

Regards,
Leonid.
___

>
>
> Thanks,
>
> tglx

\
 
 \ /
  Last update: 2020-04-27 16:36    [W:0.082 / U:1.136 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site