Messages in this thread | | | Date | Mon, 27 Apr 2020 16:00:43 +0200 | From | Borislav Petkov <> | Subject | Re: [PATCH v2 07/10] EDAC/ghes: Cleanup struct ghes_edac_dimm_fill, rename it to ghes_dimm_fill |
| |
On Wed, Apr 22, 2020 at 01:58:11PM +0200, Robert Richter wrote: > The struct is used to store temporary data for the dmidecode callback. > Clean this up a bit: > > 1) Rename member count to index since this is what it is used for. > > 2) Move code close to ghes_edac_dmidecode() where it is used. > > 3) While at it, use edac_get_dimm_by_index(). > > Signed-off-by: Robert Richter <rrichter@marvell.com> > --- > drivers/edac/ghes_edac.c | 24 ++++++++++++------------ > 1 file changed, 12 insertions(+), 12 deletions(-)
Ok except the commit title is wrong. And yes, pls keep it "dimm_fill" - short and sweet and without yet another "ghes" in the name. :)
Thx.
-- Regards/Gruss, Boris.
https://people.kernel.org/tglx/notes-about-netiquette
| |