lkml.org 
[lkml]   [2020]   [Apr]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v1] staging: fbtft: fb_st7789v: Initialize the Display
On Mon, Apr 27, 2020 at 10:36:42AM +0200, Oliver Graute wrote:
> On 09/04/20, Dan Carpenter wrote:
> > On Thu, Apr 09, 2020 at 11:25:32AM +0200, Oliver Graute wrote:
> > > From: Oliver Graute <oliver.graute@kococonnector.com>
> > >
> > > Set Gamma Values and Register Values for the HSD20_IPS
> > >
> > > Signed-off-by: Oliver Graute <oliver.graute@kococonnector.com>
> > > ---
> > > drivers/staging/fbtft/fb_st7789v.c | 12 ++++++------
> > > 1 file changed, 6 insertions(+), 6 deletions(-)
> > >
> > > diff --git a/drivers/staging/fbtft/fb_st7789v.c b/drivers/staging/fbtft/fb_st7789v.c
> > > index 84c5af2dc9a0..b0aa96b703a8 100644
> > > --- a/drivers/staging/fbtft/fb_st7789v.c
> > > +++ b/drivers/staging/fbtft/fb_st7789v.c
> > > @@ -17,8 +17,8 @@
> > > #define DRVNAME "fb_st7789v"
> > >
> > > #define DEFAULT_GAMMA \
> > > - "70 2C 2E 15 10 09 48 33 53 0B 19 18 20 25\n" \
> > > - "70 2C 2E 15 10 09 48 33 53 0B 19 18 20 25"
> > > + "D0 05 0A 09 08 05 2E 44 45 0F 17 16 2B 33\n" \
> > > + "D0 05 0A 09 08 05 2E 43 45 0F 16 16 2B 33"
> >
> > How do you know this won't break someone else's setup?
>
> Should I declare an extra define for my values?
>
> +#define HSD20_IPS_GAMMA \
> + "D0 05 0A 09 08 05 2E 44 45 0F 17 16 2B 33\n" \
> + "D0 05 0A 09 08 05 2E 43 45 0F 16 16 2B 33"
>

That's fine, but it can't be a compile time thing. Both types of
hardware have to be working/available at run time.

regards,
dan carpenter


\
 
 \ /
  Last update: 2020-04-27 11:35    [W:0.087 / U:1.148 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site