[lkml]   [2020]   [Apr]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH v3 3/4] MIPS: VDSO: Use $(LD) instead of $(CC) to link VDSO
On Mon, Apr 27, 2020 at 05:22:53PM +0100, Maciej W. Rozycki wrote:
> On Sun, 26 Apr 2020, Nathan Chancellor wrote:
> > > this causes build errors for me when (cross) compiling a big endian target:
> > >
> > > target is little endian
> > > mips64-linux-gnu-ld: arch/mips/vdso/elf.o: endianness incompatible with that of the selected emulation
> > > mips64-linux-gnu-ld: failed to merge target specific data of file arch/mips/vdso/elf.o
> >
> > Thanks for the report. I will look into it tomorrow and hopefully have a
> > v4 by then.
> Can you actually record in the change description what the difference in
> the relevant link command is, as shown where `V=1' has been used with
> `make' invocation?

That will be rather unweildy to put in the commit message since
currently, $(CC) + $(KBUILD_CFLAGS) is being used but I can if it is
really desired. Otherwise, I can just put it where I put the changelog.

> Actually running `diff -bu' on the whole `V=1' build log obtained without
> and with your proposed change applied and ensuring there are no unwanted
> changes elsewhere will be a good measure of the correctness of your patch.
> You may have to prepare to be patient and run with `-j1' to make sure any
> `make' parallelism does not interfere with the order of commands printed.
> Maciej

Thanks for the input, I will take a look.


 \ /
  Last update: 2020-04-28 01:24    [W:0.077 / U:6.084 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site