lkml.org 
[lkml]   [2020]   [Apr]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: block: remove unused header includes.
Hi Jianpeng",

Thank you for the patch! Yet something to improve:

[auto build test ERROR on linus/master]
[also build test ERROR on v5.7-rc3]
[cannot apply to block/for-next next-20200424]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url: https://github.com/0day-ci/linux/commits/Ma-Jianpeng/block-remove-unused-header-includes/20200428-045320
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 51184ae37e0518fd90cb437a2fbc953ae558cd0d
config: alpha-defconfig (attached as .config)
compiler: alpha-linux-gcc (GCC) 9.3.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day GCC_VERSION=9.3.0 make.cross ARCH=alpha

If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@intel.com>

All error/warnings (new ones prefixed by >>):

block/partitions/core.c: In function 'allocate_partitions':
>> block/partitions/core.c:94:17: error: implicit declaration of function 'vzalloc'; did you mean 'kvzalloc'? [-Werror=implicit-function-declaration]
94 | state->parts = vzalloc(array_size(nr, sizeof(state->parts[0])));
| ^~~~~~~
| kvzalloc
>> block/partitions/core.c:94:15: warning: assignment to 'struct <anonymous> *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
94 | state->parts = vzalloc(array_size(nr, sizeof(state->parts[0])));
| ^
block/partitions/core.c: In function 'free_partitions':
>> block/partitions/core.c:107:2: error: implicit declaration of function 'vfree'; did you mean 'kvfree'? [-Werror=implicit-function-declaration]
107 | vfree(state->parts);
| ^~~~~
| kvfree
cc1: some warnings being treated as errors

vim +94 block/partitions/core.c

387048bf67eeff Christoph Hellwig 2020-03-24 83
387048bf67eeff Christoph Hellwig 2020-03-24 84 static struct parsed_partitions *allocate_partitions(struct gendisk *hd)
387048bf67eeff Christoph Hellwig 2020-03-24 85 {
387048bf67eeff Christoph Hellwig 2020-03-24 86 struct parsed_partitions *state;
387048bf67eeff Christoph Hellwig 2020-03-24 87 int nr;
387048bf67eeff Christoph Hellwig 2020-03-24 88
387048bf67eeff Christoph Hellwig 2020-03-24 89 state = kzalloc(sizeof(*state), GFP_KERNEL);
387048bf67eeff Christoph Hellwig 2020-03-24 90 if (!state)
387048bf67eeff Christoph Hellwig 2020-03-24 91 return NULL;
387048bf67eeff Christoph Hellwig 2020-03-24 92
387048bf67eeff Christoph Hellwig 2020-03-24 93 nr = disk_max_parts(hd);
387048bf67eeff Christoph Hellwig 2020-03-24 @94 state->parts = vzalloc(array_size(nr, sizeof(state->parts[0])));
387048bf67eeff Christoph Hellwig 2020-03-24 95 if (!state->parts) {
387048bf67eeff Christoph Hellwig 2020-03-24 96 kfree(state);
387048bf67eeff Christoph Hellwig 2020-03-24 97 return NULL;
387048bf67eeff Christoph Hellwig 2020-03-24 98 }
387048bf67eeff Christoph Hellwig 2020-03-24 99
387048bf67eeff Christoph Hellwig 2020-03-24 100 state->limit = nr;
387048bf67eeff Christoph Hellwig 2020-03-24 101
387048bf67eeff Christoph Hellwig 2020-03-24 102 return state;
387048bf67eeff Christoph Hellwig 2020-03-24 103 }
387048bf67eeff Christoph Hellwig 2020-03-24 104
387048bf67eeff Christoph Hellwig 2020-03-24 105 static void free_partitions(struct parsed_partitions *state)
387048bf67eeff Christoph Hellwig 2020-03-24 106 {
387048bf67eeff Christoph Hellwig 2020-03-24 @107 vfree(state->parts);
387048bf67eeff Christoph Hellwig 2020-03-24 108 kfree(state);
387048bf67eeff Christoph Hellwig 2020-03-24 109 }
387048bf67eeff Christoph Hellwig 2020-03-24 110

:::::: The code at line 94 was first introduced by commit
:::::: 387048bf67eeff8bdf7c2a41b03b48230a88b3d3 block: merge partition-generic.c and check.c

:::::: TO: Christoph Hellwig <hch@lst.de>
:::::: CC: Jens Axboe <axboe@kernel.dk>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[unhandled content-type:application/gzip]
\
 
 \ /
  Last update: 2020-04-27 23:49    [W:0.112 / U:0.200 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site