lkml.org 
[lkml]   [2020]   [Apr]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] perf/script: remove extraneous newline in perf_sample__fprintf_regs()
On Sat, Apr 18, 2020 at 4:19 PM Stephane Eranian <eranian@google.com> wrote:
>
> When printing iregs, there was a double newline printed because
> perf_sample__fprintf_regs() was printing its own and then at the
> end of all fields, perf script was adding one.
> This was causing blank line in the output:
>
> Before:
> $ perf script -Fip,iregs
> 401b8d ABI:2 DX:0x100 SI:0x4a8340 DI:0x4a9340
>
> 401b8d ABI:2 DX:0x100 SI:0x4a9340 DI:0x4a8340
>
> 401b8d ABI:2 DX:0x100 SI:0x4a8340 DI:0x4a9340
>
> 401b8d ABI:2 DX:0x100 SI:0x4a9340 DI:0x4a8340
>
> After:
> $ perf script -Fip,iregs
> 401b8d ABI:2 DX:0x100 SI:0x4a8340 DI:0x4a9340
> 401b8d ABI:2 DX:0x100 SI:0x4a9340 DI:0x4a8340
> 401b8d ABI:2 DX:0x100 SI:0x4a8340 DI:0x4a9340
>
> Signed-off-by: Stephane Eranian <eranian@google.com>


Ping?

>
> ---
> tools/perf/builtin-script.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/tools/perf/builtin-script.c b/tools/perf/builtin-script.c
> index 1f57a7ecdf3d0..0c0b6e807d06e 100644
> --- a/tools/perf/builtin-script.c
> +++ b/tools/perf/builtin-script.c
> @@ -604,8 +604,6 @@ static int perf_sample__fprintf_regs(struct regs_dump *regs, uint64_t mask,
> printed += fprintf(fp, "%5s:0x%"PRIx64" ", perf_reg_name(r), val);
> }
>
> - fprintf(fp, "\n");
> -
> return printed;
> }
>
> --
> 2.26.1.301.g55bc3eb7cb9-goog
>

\
 
 \ /
  Last update: 2020-04-27 23:44    [W:0.125 / U:0.748 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site