[lkml]   [2020]   [Apr]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [v2 2/3] net: qrtr: Add MHI transport layer

On 27 April 2020 12:20:43 PM IST, Markus Elfring <> wrote:
>>> I propose again to add a jump target so that a bit of exception
>handling code
>>> can be better reused at the end of this function implementation.
>> Matter of taste! goto's are really useful if there are multiple exit
>> available. But in this case there is only one and I don't think we
>may add
>> anymore in future. So I'll keep it as it is.
>Do you hope that an other optimiser software will avoid duplicate code
>like kfree_skb(skb) calls from if branches?

Doh. I didn't notice the previous kfree in skb_linearize(). Will spin v3 incorporating this change.



Sent from my Android device with K-9 Mail. Please excuse my brevity.

 \ /
  Last update: 2020-04-27 08:59    [W:0.083 / U:3.676 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site