Messages in this thread | | | Subject | Re: [v2 2/3] net: qrtr: Add MHI transport layer | From | Markus Elfring <> | Date | Mon, 27 Apr 2020 08:50:43 +0200 |
| |
>> I propose again to add a jump target so that a bit of exception handling code >> can be better reused at the end of this function implementation. >> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?id=b2768df24ec400dd4f7fa79542f797e904812053#n450 >> > > Matter of taste! goto's are really useful if there are multiple exit paths > available. But in this case there is only one and I don't think we may add > anymore in future. So I'll keep it as it is.
Do you hope that an other optimiser software will avoid duplicate code like kfree_skb(skb) calls from if branches?
Regards, Markus
| |