Messages in this thread | | | Subject | Re: [PATCH v3 2/4] hugetlbfs: move hugepagesz= parsing to arch independent code | From | Mike Kravetz <> | Date | Mon, 27 Apr 2020 13:31:06 -0700 |
| |
On 4/27/20 1:18 PM, Andrew Morton wrote: > On Mon, 27 Apr 2020 12:09:47 -0700 Mike Kravetz <mike.kravetz@oracle.com> wrote: > >> Previously, a check for hugepages_supported was added before processing >> hugetlb command line parameters. On some architectures such as powerpc, >> hugepages_supported() is not set to true until after command line >> processing. Therefore, no hugetlb command line parameters would be >> accepted. >> >> Remove the additional checks for hugepages_supported. In hugetlb_init, >> print a warning if !hugepages_supported and command line parameters were >> specified. > > This applies to [4/4] instead of fixing [2/4]. I guess you'll > straighten that out in v4?
Yes.
> btw, was > http://lkml.kernel.org/r/CADYN=9Koefrq9H1Y82Q8nMNbeyN4tzhEfvDu5u=sVFjFZCYorA@mail.gmail.com > addressed?
Yes, you pulled a patch into your tree to address this. hugetlbfs-remove-hugetlb_add_hstate-warning-for-existing-hstate-fix.patch
I'll send out a v4 with both these issues addressed. Would like to wait until receiving confirmation from someone who can test on powerpc. -- Mike Kravetz
| |