Messages in this thread | | | From | Chun-Kuang Hu <> | Date | Sun, 26 Apr 2020 16:20:39 +0800 | Subject | Re: [PATCH -next] drm/mediatek: Fix Kconfig warning |
| |
Hi, YueHaibing:
YueHaibing <yuehaibing@huawei.com> 於 2020年4月20日 週一 下午10:04寫道: > > WARNING: unmet direct dependencies detected for MTK_MMSYS > Depends on [n]: (ARCH_MEDIATEK [=y] || COMPILE_TEST [=n]) && COMMON_CLK_MT8173_MMSYS [=n] > Selected by [y]: > - DRM_MEDIATEK [=y] && HAS_IOMEM [=y] && DRM [=y] && (ARCH_MEDIATEK [=y] || ARM && COMPILE_TEST [=n]) && COMMON_CLK [=y] && HAVE_ARM_SMCCC [=y] && OF [=y] > > Add missing dependcy COMMON_CLK_MT8173_MMSYS to fix this.
From the code relationship, mediatek drm has relation with mediatek mmsys, and mediatek mmsys has relation with medaitek clock. So I think it's better that CONFIG_MTK_MMSYS select CONFIG_COMMON_CLK_MT8173_MMSYS.
Regards, Chun-Kuang.
> > Fixes: 2c758e301ed9 ("soc / drm: mediatek: Move routing control to mmsys device") > Signed-off-by: YueHaibing <yuehaibing@huawei.com> > --- > drivers/gpu/drm/mediatek/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/mediatek/Kconfig b/drivers/gpu/drm/mediatek/Kconfig > index c420f5a3d33b..4d9b5540de68 100644 > --- a/drivers/gpu/drm/mediatek/Kconfig > +++ b/drivers/gpu/drm/mediatek/Kconfig > @@ -6,6 +6,7 @@ config DRM_MEDIATEK > depends on COMMON_CLK > depends on HAVE_ARM_SMCCC > depends on OF > + depends on COMMON_CLK_MT8173_MMSYS > select DRM_GEM_CMA_HELPER > select DRM_KMS_HELPER > select DRM_MIPI_DSI > -- > 2.17.1 > >
| |