Messages in this thread | | | Date | Sun, 26 Apr 2020 09:54:25 +0200 | From | Wolfram Sang <> | Subject | Re: [PATCH v3 2/2] i2c: i2c-stm32f7: allows for any bus frequency |
| |
On Mon, Apr 20, 2020 at 04:57:57PM +0200, Alain Volmat wrote: > Do not limitate to the 3 (100KHz, 400KHz, 1MHz) bus frequency but > instead allows any frequency (if it matches timing requirements). > Depending on the requested frequency, use the spec data from either > Standard, Fast or Fast Plus mode. > > Hardcoding of min/max bus frequencies is removed and is instead computed. > > The driver do not use anymore speed identifier but instead handle > directly the frequency and figure out the spec data (necessary > for the computation of the timing register) based on the frequency. > > Signed-off-by: Alain Volmat <alain.volmat@st.com> > Reviewed-by: Pierre-Yves MORDRET <pierre-yves.mordret@st.com>
Fixed this checkpatch CHECK:
CHECK: Macro argument 'rate' may be better as '(rate)' to avoid precedence issues #133: FILE: drivers/i2c/busses/i2c-stm32f7.c:413: +#define RATE_MIN(rate) (rate * 8 / 10)
and applied to for-next.
If you could drop the 'i2c-' prefix in $subject, that would save me one step.
Thanks!
[unhandled content-type:application/pgp-signature] | |