Messages in this thread | | | Date | Sun, 26 Apr 2020 19:29:54 +0200 | From | Michał Mirosław <> | Subject | Re: [PATCH v4 03/10] input: elants: remove unused axes |
| |
On Sun, Apr 26, 2020 at 07:35:47PM +0300, Dmitry Osipenko wrote: > 26.04.2020 19:11, Michał Mirosław пишет: > > Driver only ever reports MT events and input_mt_init_slots() sets up > > emulated axes already. Clear the capabilities not generated directly > > and move MT axes setup, so they are visible by input_mt_init_slots(). > > > > Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl> > > Reviewed-by: Dmitry Osipenko <digetx@gmail.com> > > Tested-by: Dmitry Osipenko <digetx@gmail.com> > > --- > > v4: reword commitmsg; reorder axis setup > > --- > > Legacy pointer emulation doesn't work using v4. I think it will be > better to drop this patch for now and add this hunk to the patch #4:
Have you tried it together with the next patch? It adds touchscreen_parse_properties() to initialize axes also from DT, and should be equivalent to the hunk you proposed.
[...] > Maybe input_mt_init_slots() could be changed to set up all the > properties that are needed for the legacy pointer, but I'm not 100% sure > because not very familiar with that code. Perhaps Dmitry Torokhov could > clarify?
The code of input_mt_init_slots() looks like it does initialize the properties needed. What does evtest return with and without the patches?
Best Regards Michał Mirosław
| |