Messages in this thread | | | Subject | Re: [PATCH] drivers: staging: rts5208: rtsx.c fix Unbalanced braces around else statement issue | From | Joe Perches <> | Date | Sun, 26 Apr 2020 10:22:53 -0700 |
| |
On Sun, 2020-04-26 at 17:02 +0100, John Oldman wrote: > Fix coding style issue > > Signed-off-by: John Oldman <john.oldman@polehill.co.uk> > --- > drivers/staging/rts5208/rtsx.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/staging/rts5208/rtsx.c b/drivers/staging/rts5208/rtsx.c > index be0053c795b7..ca836ca2ee81 100644 > --- a/drivers/staging/rts5208/rtsx.c > +++ b/drivers/staging/rts5208/rtsx.c > @@ -419,10 +419,8 @@ static int rtsx_control_thread(void *__dev) > chip->srb->device->id, > (u8)chip->srb->device->lun); > chip->srb->result = DID_BAD_TARGET << 16; > - } > - > - /* we've got a command, let's do it! */ > - else { > + } else { > + /* we've got a command, let's do it! */ > scsi_show_command(chip); > rtsx_invoke_transport(chip->srb, chip); > }
Please look at the code blocks you are changing and if you are trying to fix unbalanced else blocks, do all the blocks, not just one of many consecutive.
/* reject the command if the direction indicator * is UNKNOWN */ if (chip->srb->sc_data_direction == DMA_BIDIRECTIONAL) { dev_err(&dev->pci->dev, "UNKNOWN data direction\n"); chip->srb->result = DID_ERROR << 16; }
/* reject if target != 0 or if LUN is higher than * the maximum known LUN */ else if (chip->srb->device->id) { dev_err(&dev->pci->dev, "Bad target number (%d:%d)\n", chip->srb->device->id, (u8)chip->srb->device->lun); chip->srb->result = DID_BAD_TARGET << 16; }
else if (chip->srb->device->lun > chip->max_lun) { dev_err(&dev->pci->dev, "Bad LUN (%d:%d)\n", chip->srb->device->id, (u8)chip->srb->device->lun); chip->srb->result = DID_BAD_TARGET << 16; }
/* we've got a command, let's do it! */ else { scsi_show_command(chip); rtsx_invoke_transport(chip->srb, chip); }
| |