Messages in this thread | | | Subject | Re: [PATCH] ray_cs: use true,false for bool variable | From | Sergei Shtylyov <> | Date | Sun, 26 Apr 2020 12:47:37 +0300 |
| |
Hello!
On 26.04.2020 12:41, Jason Yan wrote:
> Fix the following coccicheck warning: > > drivers/net/wireless/ray_cs.c:2797:5-14: WARNING: Comparison of 0/1 to > bool variable > drivers/net/wireless/ray_cs.c:2798:2-11: WARNING: Assignment of 0/1 to > bool variable > > Signed-off-by: Jason Yan <yanaijie@huawei.com> > --- > drivers/net/wireless/ray_cs.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/wireless/ray_cs.c b/drivers/net/wireless/ray_cs.c > index c1d542bfa530..f9402424accd 100644 > --- a/drivers/net/wireless/ray_cs.c > +++ b/drivers/net/wireless/ray_cs.c > @@ -2794,8 +2794,8 @@ static int __init init_ray_cs(void) > proc_create_data("driver/ray_cs/translate", 0200, NULL, &int_proc_ops, > &translate); > #endif > - if (translate != 0) > - translate = 1; > + if (!translate)
That inverts the original logic, no?
> + translate = true;
Actually, that whole comparison/assignment doesn't make sense, if we use bool...
[...]
MBR, Sergei
| |