Messages in this thread | | | Subject | Re: [RFC PATCH v10 6/9] media: tegra: Add Tegra210 Video input driver | From | Sowjanya Komatineni <> | Date | Sat, 25 Apr 2020 17:24:28 -0700 |
| |
On 4/25/20 5:19 PM, Dmitry Osipenko wrote: > External email: Use caution opening links or attachments > > > 26.04.2020 02:44, Sowjanya Komatineni пишет: > ... >>> How much of the T210 code could be reused by T186/194? >> vi/csi are common driver where soc structure should be populated for >> T186/T194 >> >> Tegra210.c can't be reused for Tegra186/t194 as programming seq is a >> whole lot diff >> > How are you going to separate Tegra210/186/194 drivers from each other? > I don't think you'll want to have one "fat" driver that covers all those > SoCs, won't you? > > In the end it should be three modules: tegra210-video.ko > tegra186-video.ko tegra194-video.ko. > > Using a per-SoC OPS doesn't allow you to do that because the "root" > driver will have to lookup OPS' code symbols of every SoC, and thus, the > unwanted driver modules will get auto-loaded if you'll try to factor out > the OPS into a separate driver modules.
tegra-video driver will be common for t210/186/194
we add corresponding compatibles to tegra-video and vi/csi drivers along with that need to add tegra186_vi_soc, tegra194_vi_soc and implement tegra186.c/tegra194.c
tegra-video driver updated for later tegra include updating drivers list and subdevs list to add t186/t194 compatibles
| |