Messages in this thread | | | Subject | Re: [RFC PATCH v10 6/9] media: tegra: Add Tegra210 Video input driver | From | Sowjanya Komatineni <> | Date | Sat, 25 Apr 2020 16:44:04 -0700 |
| |
On 4/25/20 4:40 PM, Dmitry Osipenko wrote: > External email: Use caution opening links or attachments > > > 26.04.2020 01:11, Sowjanya Komatineni пишет: >> On 4/25/20 3:08 PM, Dmitry Osipenko wrote: >>> External email: Use caution opening links or attachments >>> >>> >>> 25.04.2020 01:00, Sowjanya Komatineni пишет: >>>> On 4/24/20 8:07 AM, Dmitry Osipenko wrote: >>>>> External email: Use caution opening links or attachments >>>>> >>>>> >>>>> 24.04.2020 06:55, Sowjanya Komatineni пишет: >>>>> >>>>> Is this driver compiled as a single kernel module file? >>>>> >>>>>> +MODULE_AUTHOR("Sowjanya Komatineni <skomatineni@nvidia.com>"); >>>>>> +MODULE_DESCRIPTION("NVIDIA Tegra CSI Device Driver"); >>>>>> +MODULE_LICENSE("GPL v2"); >>>>> ... >>>>>> +MODULE_AUTHOR("Sowjanya Komatineni <skomatineni@nvidia.com>"); >>>>>> +MODULE_DESCRIPTION("NVIDIA Tegra Video Input Device Driver"); >>>>>> +MODULE_LICENSE("GPL v2"); >>>>> I don't think that these macros are needed in that case. >>>>> The video.c should be enough, isn't it? >>>> yes these can be removed >>> It will be nice to factor out the Tegra210-specific VI/CSI OPS into a >>> separate driver module (say tegra210-vi) to ease supporting of other >>> Tegra versions. Of course this could be done later on, although I >>> suppose the amount of hassle could be reduced if it's done from the >>> start. >> vi/csi.c are common drivers for all Tegras. All Tegra chip specific >> related programming for both vi and csi were already moved to Tegra210.c >> based on prior feedbacks. > Judging by the code's structure the VI/CSI drivers aren't planned to be > reused by older pre-Terga210 SoCs, correct? > > How much of the T210 code could be reused by T186/194?
vi/csi are common driver where soc structure should be populated for T186/T194
Tegra210.c can't be reused for Tegra186/t194 as programming seq is a whole lot diff
| |