Messages in this thread | | | Subject | Re: [RFC PATCH 1/3] kvm: x86: Rename KVM_DEBUGREG_RELOAD to KVM_DEBUGREG_NEED_RELOAD | From | Paolo Bonzini <> | Date | Sat, 25 Apr 2020 09:48:17 +0200 |
| |
On 24/04/20 22:21, Peter Xu wrote: > But then shouldn't DIRTY be set as long as KVM_DEBUGREG_BP_ENABLED is set every > time before vmenter? Then it'll somehow go back to switch_db_regs, iiuc... > > IIUC RELOAD actually wants to say "reload only for this iteration", that's why > it's cleared after each reload. So maybe... RELOAD_ONCE? > > (Btw, do we have debug regs tests somewhere no matter inside guest or with > KVM_SET_GUEST_DEBUG?)
What about KVM_DEBUGREG_EFF_DB_DIRTY?
We have them in kvm-unit-tests for debug regs inside the guest, but no selftests covering KVM_SET_GUEST_DEBUG.
Paolo
| |