lkml.org 
[lkml]   [2020]   [Apr]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] kvm/eventfd: remove unneeded conversion to bool
From
Date
On 20/04/20 14:38, Jason Yan wrote:
> The '==' expression itself is bool, no need to convert it to bool again.
> This fixes the following coccicheck warning:
>
> virt/kvm/eventfd.c:724:38-43: WARNING: conversion to bool not needed
> here
>
> Signed-off-by: Jason Yan <yanaijie@huawei.com>
> ---
> virt/kvm/eventfd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/virt/kvm/eventfd.c b/virt/kvm/eventfd.c
> index 67b6fc153e9c..0c4ede45e6bd 100644
> --- a/virt/kvm/eventfd.c
> +++ b/virt/kvm/eventfd.c
> @@ -721,7 +721,7 @@ ioeventfd_in_range(struct _ioeventfd *p, gpa_t addr, int len, const void *val)
> return false;
> }
>
> - return _val == p->datamatch ? true : false;
> + return _val == p->datamatch;
> }
>
> /* MMIO/PIO writes trigger an event if the addr/val match */
>

Queued, thanks.

Paolo

\
 
 \ /
  Last update: 2020-04-25 12:44    [W:0.072 / U:0.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site