lkml.org 
[lkml]   [2020]   [Apr]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v2 87/91] drm/vc4: hdmi: Set the b-frame marker to the match ALSA's default.
    Date
    From: Dave Stevenson <dave.stevenson@raspberrypi.com>

    ALSA's iec958 plugin by default sets the block start preamble
    to 8, whilst this driver was programming the hardware to expect
    0xF.
    Amend the hardware config to match ALSA.

    Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
    Signed-off-by: Maxime Ripard <maxime@cerno.tech>
    ---
    drivers/gpu/drm/vc4/vc4_hdmi.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    diff --git a/drivers/gpu/drm/vc4/vc4_hdmi.c b/drivers/gpu/drm/vc4/vc4_hdmi.c
    index cac55386236f..7c43c039e669 100644
    --- a/drivers/gpu/drm/vc4/vc4_hdmi.c
    +++ b/drivers/gpu/drm/vc4/vc4_hdmi.c
    @@ -756,10 +756,11 @@ static int vc4_hdmi_audio_hw_params(struct snd_pcm_substream *substream,

    vc4_hdmi_audio_set_mai_clock(vc4_hdmi);

    + /* The B frame identifier should match the value used by alsa-lib (8) */
    audio_packet_config =
    VC4_HDMI_AUDIO_PACKET_ZERO_DATA_ON_SAMPLE_FLAT |
    VC4_HDMI_AUDIO_PACKET_ZERO_DATA_ON_INACTIVE_CHANNELS |
    - VC4_SET_FIELD(0xf, VC4_HDMI_AUDIO_PACKET_B_FRAME_IDENTIFIER);
    + VC4_SET_FIELD(0x8, VC4_HDMI_AUDIO_PACKET_B_FRAME_IDENTIFIER);

    channel_mask = GENMASK(vc4_hdmi->audio.channels - 1, 0);
    audio_packet_config |= VC4_SET_FIELD(channel_mask,
    --
    git-series 0.9.1
    \
     
     \ /
      Last update: 2020-04-24 17:38    [W:4.080 / U:0.316 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site