Messages in this thread | | | Date | Fri, 24 Apr 2020 21:44:07 +0800 | From | Yang Weijiang <> | Subject | Re: [PATCH v11 1/9] KVM: VMX: Introduce CET VMX fields and flags |
| |
On Thu, Apr 23, 2020 at 09:39:48AM -0700, Sean Christopherson wrote: > On Thu, Mar 26, 2020 at 04:18:38PM +0800, Yang Weijiang wrote: > > If VM_EXIT_LOAD_HOST_CET_STATE = 1, the host CET states are restored > > from below VMCS fields at VM-Exit: > > HOST_S_CET > > HOST_SSP > > HOST_INTR_SSP_TABLE > > > > If VM_ENTRY_LOAD_GUEST_CET_STATE = 1, the guest CET states are loaded > > from below VMCS fields at VM-Entry: > > GUEST_S_CET > > GUEST_SSP > > GUEST_INTR_SSP_TABLE > > > > Co-developed-by: Zhang Yi Z <yi.z.zhang@linux.intel.com> > > Signed-off-by: Zhang Yi Z <yi.z.zhang@linux.intel.com> > > Signed-off-by: Yang Weijiang <weijiang.yang@intel.com> > > --- > > ... > > > diff --git a/arch/x86/include/asm/vmx.h b/arch/x86/include/asm/vmx.h > > index 5e090d1f03f8..e938bc6c37aa 100644 > > --- a/arch/x86/include/asm/vmx.h > > +++ b/arch/x86/include/asm/vmx.h > > @@ -94,6 +94,7 @@ > > #define VM_EXIT_CLEAR_BNDCFGS 0x00800000 > > #define VM_EXIT_PT_CONCEAL_PIP 0x01000000 > > #define VM_EXIT_CLEAR_IA32_RTIT_CTL 0x02000000 > > +#define VM_EXIT_LOAD_HOST_CET_STATE 0x10000000 > > > > #define VM_EXIT_ALWAYSON_WITHOUT_TRUE_MSR 0x00036dff > > > > @@ -107,6 +108,7 @@ > > #define VM_ENTRY_LOAD_BNDCFGS 0x00010000 > > #define VM_ENTRY_PT_CONCEAL_PIP 0x00020000 > > #define VM_ENTRY_LOAD_IA32_RTIT_CTL 0x00040000 > > +#define VM_ENTRY_LOAD_GUEST_CET_STATE 0x00100000 > > I think it probably make senses to drop HOST/GUEST from the controls, > i.e. VM_{ENTER,EXIT}_LOAD_CET_STATE. The SDM doesn't qualify them with > guest vs. host, nor does KVM qualify any of the other entry/exit controls > that are effective guest vs. host. Sure, will fix them, thanks.
| |