lkml.org 
[lkml]   [2020]   [Apr]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [net-next PATCH v1 2/2] phylink: introduce phylink_fwnode_phy_connect()
On Fri, Apr 24, 2020 at 6:17 AM Calvin Johnson
<calvin.johnson@oss.nxp.com> wrote:
>
> Define phylink_fwnode_phy_connect() to connect phy specified by
> a fwnode to a phylink instance. This function will handle both
> DT and ACPI nodes.

> #include <linux/spinlock.h>
> #include <linux/timer.h>
> #include <linux/workqueue.h>
> +#include <linux/acpi.h>

Looks like broken order.

> + if (is_of_node(fwnode)) {
> + } else if (is_acpi_node(fwnode)) {
> + }

I'm wondering if there is an API that allows you to drop all this
stuff. In property provider agnostic code we really don't want to see
this.

> + if (!phy_dev)
> + return -ENODEV;

--
With Best Regards,
Andy Shevchenko

\
 
 \ /
  Last update: 2020-04-24 11:57    [W:0.107 / U:0.232 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site