Messages in this thread | | | From | Andy Shevchenko <> | Date | Fri, 24 Apr 2020 12:50:30 +0300 | Subject | Re: [PATCH 1/1] pinctrl: add IRQF_EARLY_RESUME flags with gpio irq for elan touchpad. |
| |
On Fri, Apr 24, 2020 at 12:16 PM <caizhaopeng@uniontech.com> wrote: > > From: Caicai <caizhaopeng@uniontech.com> > > I had tested two Notebook machines, the Intel i5(or amd ryzen) > with elan touchpad, and there's a probability that the touchpad > won't work after going to the S3/S4 to wake up, that it would > appear no more than 15 times. I found that there's no interrupt > to check for /proc/interrupt. It was found that the gpio > interrupt of i2c was also not on top. By adding the gpio > interrupt flags with IRQF_EARLY_RESUME, now the touchpad tested > 200 + times works well.
Thanks for the contribution!
You need a) to split this to patch per driver (I can't take or speak for AMD code, I'm not a maintainer and don't have hardware) b) explain what this flag actually means and does
On top of that we need to test this widely to avoid regressions.
-- With Best Regards, Andy Shevchenko
| |