Messages in this thread | | | Subject | Re: [PATCH v6 04/10] PM / EM: add support for other devices than CPUs in Energy Model | From | Lukasz Luba <> | Date | Thu, 23 Apr 2020 18:19:03 +0100 |
| |
On 4/23/20 6:15 PM, Daniel Lezcano wrote: > On 23/04/2020 18:57, Lukasz Luba wrote: >> >> >> On 4/23/20 4:12 PM, Daniel Lezcano wrote: >>> On Fri, Apr 10, 2020 at 09:42:04AM +0100, Lukasz Luba wrote: >>>> Add support for other devices that CPUs. The registration function >>>> does not require a valid cpumask pointer and is ready to handle new >>>> devices. Some of the internal structures has been reorganized in >>>> order to >>>> keep consistent view (like removing per_cpu pd pointers). To track usage >>>> of the Energy Model structures, they are protected with kref. >>> >>> Why not add the energy model structure in the struct device directly? >> >> Do you mean this structure? >> https://elixir.bootlin.com/linux/latest/source/include/linux/device.h#L537 >> >> and to put something like: >> struct device { >> ... >> struct dev_pm_domain *pm_domain; >> #ifdef CONFIG_ENERGY_MODEL >> struct em_perf_domain *em_pd; >> #endif >> ... >> }; > > Yes, exactly. >
Thank you for the confirmation. I am going to start working on it.
BTW, thank you for all of the ACKs and reviews.
Regards, Lukasz
| |