lkml.org 
[lkml]   [2020]   [Apr]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v1] console: fix an issue about ioremap leak.
On Thu, Apr 23, 2020 at 01:10:14PM +0200, Markus Elfring wrote:
> > if do_take_over_console() return an error in the newport_probe(),
> > due to the io virtual address is not released, it will cause a leak.
>
> How do you think about a wording variant like the following?
>
> Subject:
> [PATCH v2] console: Complete exception handling in newport_probe()
>
> Change description:
> A call of the function “do_take_over_console” can fail here.
> The corresponding system resources were not released then.
> Thus add a call of the function “iounmap” together with the check
> of a failure predicate.
>
Thanks!

>
> I would like to point out that there is a script for the semantic
> patch language which would detect other questionable source code.
> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/log/scripts/coccinelle/free/iounmap.cocci
>
> How do you think about to extend presented software analysis approaches?
>
Sorry, I am not familiar with it, I don't know.

BR,
Dejin

> Regards,
> Markus

\
 
 \ /
  Last update: 2020-04-23 16:29    [W:0.083 / U:0.812 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site