lkml.org 
[lkml]   [2020]   [Apr]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRE: [PATCH] scsi: storvsc: Fix a panic in the hibernation procedure
    Date
    > From: Bart Van Assche <bvanassche@acm.org>
    > Sent: Thursday, April 23, 2020 4:25 PM
    > On 2020-04-23 11:29, Dexuan Cui wrote:
    > > So it looks the below patch also works for me:
    > >
    > > --- a/kernel/power/hibernate.c
    > > +++ b/kernel/power/hibernate.c
    > > @@ -898,6 +898,11 @@ static int software_resume(void)
    > > error = freeze_processes();
    > > if (error)
    > > goto Close_Finish;
    > > +
    > > + error = freeze_kernel_threads();
    > > + if (error)
    > > + goto Close_Finish;
    > > +
    > > error = load_image_and_restore();
    > > thaw_processes();
    > > Finish:
    > >
    > > Just to be sure, I'll do more tests, but I believe the panic can be fixed
    > > by this according to my tests I have done so far.
    >
    > If a freeze_kernel_threads() call is added in software_resume(), should
    > a thaw_kernel_threads() call be added too?
    >
    > Anyway, please Cc me if a patch for software_resume() is submitted.

    FYI, I posted a fix: https://lkml.org/lkml/2020/4/23/1540

    Thanks,
    -- Dexuan
    \
     
     \ /
      Last update: 2020-04-24 05:46    [W:3.053 / U:0.776 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site