Messages in this thread | | | Subject | Re: [PATCH] selftests: add build/cross-build dependency check script | From | Randy Dunlap <> | Date | Thu, 23 Apr 2020 20:25:28 -0700 |
| |
Hi,
On 4/14/20 2:22 PM, Shuah Khan wrote: > -CFLAGS += -O2 -g -std=gnu99 -Wall -I../../../../usr/include/ $(MOUNT_CFLAGS) > -LDLIBS += $(MOUNT_LDLIBS) > +CFLAGS += -O2 -g -std=gnu99 -Wall -I../../../../usr/include/ $(VAR_CFLAGS) > +LDLIBS += $(VAR_LDLIBS)
(1) Can that series of ../../../.. be replaced by $(objtree)? If so, that would be much cleaner IMO.
(2) I can't find anything that checks that ../../../../usr/include exists (or has been installed via 'make headers_install'). Or anything that requires that CONFIG_HEADERS_INSTALL be set/enabled. Well, other than a Makefile error, but that's not a nice way to find out.
Preferably we would have some Kconfig check/enforcement or at least some documentation.
Thoughts?
thanks. -- ~Randy
| |