lkml.org 
[lkml]   [2020]   [Apr]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 3.16 001/245] mwifiex: fix unbalanced locking in mwifiex_process_country_ie()
    3.16.83-rc1 review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Brian Norris <briannorris@chromium.org>

    commit 65b1aae0d9d5962faccc06bdb8e91a2a0b09451c upstream.

    We called rcu_read_lock(), so we need to call rcu_read_unlock() before
    we return.

    Fixes: 3d94a4a8373b ("mwifiex: fix possible heap overflow in mwifiex_process_country_ie()")
    Cc: huangwen <huangwenabc@gmail.com>
    Cc: Ganapathi Bhat <ganapathi.bhat@nxp.com>
    Signed-off-by: Brian Norris <briannorris@chromium.org>
    Acked-by: Ganapathi Bhat <ganapathi.bhat@nxp.com>
    Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
    [bwh: Backported to 3.16: adjust filename, context]
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    drivers/net/wireless/mwifiex/sta_ioctl.c | 1 +
    1 file changed, 1 insertion(+)

    --- a/drivers/net/wireless/mwifiex/sta_ioctl.c
    +++ b/drivers/net/wireless/mwifiex/sta_ioctl.c
    @@ -226,6 +226,7 @@ static int mwifiex_process_country_ie(st

    if (country_ie_len >
    (IEEE80211_COUNTRY_STRING_LEN + MWIFIEX_MAX_TRIPLET_802_11D)) {
    + rcu_read_unlock();
    wiphy_dbg(priv->wdev->wiphy,
    "11D: country_ie_len overflow!, deauth AP\n");
    return -EINVAL;
    \
     
     \ /
      Last update: 2020-04-24 01:26    [W:4.205 / U:0.096 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site