lkml.org 
[lkml]   [2020]   [Apr]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 3.16 184/245] r8152: add missing endpoint sanity check
    3.16.83-rc1 review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Johan Hovold <johan@kernel.org>

    commit 86f3f4cd53707ceeec079b83205c8d3c756eca93 upstream.

    Add missing endpoint sanity check to probe in order to prevent a
    NULL-pointer dereference (or slab out-of-bounds access) when retrieving
    the interrupt-endpoint bInterval on ndo_open() in case a device lacks
    the expected endpoints.

    Fixes: 40a82917b1d3 ("net/usb/r8152: enable interrupt transfer")
    Cc: hayeswang <hayeswang@realtek.com>
    Signed-off-by: Johan Hovold <johan@kernel.org>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    drivers/net/usb/r8152.c | 3 +++
    1 file changed, 3 insertions(+)

    --- a/drivers/net/usb/r8152.c
    +++ b/drivers/net/usb/r8152.c
    @@ -3425,6 +3425,9 @@ static int rtl8152_probe(struct usb_inte
    return -ENODEV;
    }

    + if (intf->cur_altsetting->desc.bNumEndpoints < 3)
    + return -ENODEV;
    +
    usb_reset_device(udev);
    netdev = alloc_etherdev(sizeof(struct r8152));
    if (!netdev) {
    \
     
     \ /
      Last update: 2020-04-24 01:11    [W:4.127 / U:0.156 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site