lkml.org 
[lkml]   [2020]   [Apr]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 018/118] of: overlay: kmemleak in dup_and_fixup_symbol_prop()
    Date
    From: Frank Rowand <frank.rowand@sony.com>

    commit 478ff649b1c8eb2409b1a54fb75eb46f7c29f140 upstream.

    kmemleak reports several memory leaks from devicetree unittest.
    This is the fix for problem 4 of 5.

    target_path was not freed in the non-error path.

    Fixes: e0a58f3e08d4 ("of: overlay: remove a dependency on device node full_name")
    Reported-by: Erhard F. <erhard_f@mailbox.org>
    Signed-off-by: Frank Rowand <frank.rowand@sony.com>
    Signed-off-by: Rob Herring <robh@kernel.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/of/overlay.c | 2 ++
    1 file changed, 2 insertions(+)

    --- a/drivers/of/overlay.c
    +++ b/drivers/of/overlay.c
    @@ -261,6 +261,8 @@ static struct property *dup_and_fixup_sy

    of_property_set_flag(new_prop, OF_DYNAMIC);

    + kfree(target_path);
    +
    return new_prop;

    err_free_new_prop:

    \
     
     \ /
      Last update: 2020-04-22 12:47    [W:4.438 / U:0.336 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site