Messages in this thread | | | Subject | Re: [PATCH v2 06/10] mmc: meson-mx-sdio: Depend on OF_ADDRESS and not just OF | From | Stephen Boyd <> | Date | Wed, 22 Apr 2020 03:14:20 -0700 |
| |
Quoting Ulf Hansson (2020-04-21 07:04:54) > On Thu, 9 Apr 2020 at 08:44, Stephen Boyd <sboyd@kernel.org> wrote: > > > > Making COMMON_CLK a visible option causes the sparc allyesconfig to fail > > to build like so: > > > > sparc64-linux-ld: drivers/mmc/host/meson-mx-sdio.o: in function `meson_mx_mmc_remove': > > meson-mx-sdio.c:(.text+0x70): undefined reference to `of_platform_device_destroy' > > sparc64-linux-ld: drivers/mmc/host/meson-mx-sdio.o: in function `meson_mx_mmc_probe': > > meson-mx-sdio.c:(.text+0x9e4): undefined reference to `of_platform_device_create' > > sparc64-linux-ld: meson-mx-sdio.c:(.text+0xdd4): undefined reference to `of_platform_device_destroy' > > > > This is because the implementation of of_platform_device_destroy() is > > inside an #ifdef CONFIG_OF_ADDRESS section of drivers/of/platform.c. > > This driver already depends on OF being enabled, so let's tighten that > > constrain a little more so that it depends on OF_ADDRESS instead. This > > way we won't try to build this driver on platforms that don't have this > > function. > > > > Reported-by: kbuild test robot <lkp@intel.com> > > Cc: Neil Armstrong <narmstrong@baylibre.com> > > Cc: Ulf Hansson <ulf.hansson@linaro.org> > > Signed-off-by: Stephen Boyd <sboyd@kernel.org> > > I don't have the complete picture here, can I just apply this a fix to > my mmc tree? >
If this patch stays in the series then I can avoid a bisection hole. And it also doesn't matter until COMMON_CLK config becomes selectable. Maybe just ack and let it go through clk tree? Unless there's something changing here in the mmc tree?
| |