lkml.org 
[lkml]   [2020]   [Apr]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 5/5] sysctl: pass kernel pointers to ->proc_handler
Christoph Hellwig <hch@lst.de> [Wed, 2020-04-22 10:23 -0700]:
> On Tue, Apr 21, 2020 at 12:23:30PM -0700, Andrey Ignatov wrote:
> > > if (ret == 1 && ctx.new_updated) {
> > > - *new_buf = ctx.new_val;
> > > + *buf = ctx.new_val;
> >
> > Original value of *buf should be freed before overriding it here
> > otherwise it's lost/leaked unless I missed something.
> >
> > Other than this BPF part of this patch looks good to me. Feel free to
> > add my Ack on the next iteration with this fix.
>
> Thanks, fixed.
>
> Can you also comment on "bpf-cgroup: remove unused exports" ?

Sure, reviewed.

--
Andrey Ignatov

\
 
 \ /
  Last update: 2020-04-23 01:40    [W:0.052 / U:0.884 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site