Messages in this thread | | | Subject | Re: [PATCH v4 4/7] kernel.h: Split out min()/max() et al helpers | From | Joe Perches <> | Date | Wed, 22 Apr 2020 08:51:35 -0700 |
| |
On Wed, 2020-04-22 at 18:44 +0300, Andy Shevchenko wrote: > On Wed, Apr 22, 2020 at 07:52:32AM -0700, Joe Perches wrote: > > On Wed, 2020-04-22 at 15:51 +0300, Andy Shevchenko wrote: > > > kernel.h is being used as a dump for all kinds of stuff for a long time. > > > Here is the attempt to start cleaning it up by splitting out min()/max() > > > et al helpers. > > > > While adding organization into kernel.h by splitting > > out various bits into separate files is a fine idea, > > I believe removing the generic #include <linux/kernel.h> > > from various files and substituting the sub-includes > > is not a good idea. > > Are you sure?
Yes.
> Perhaps we may just cat include/linux/* > include/linux/kernel.h?
Silly argument, There's a real argument to be made to tmove many of the files in include/linux to separate directories or out of include/ altogether to subsystem specific locations.
| |