Messages in this thread | | | Subject | Re: [PATCH] ASoC: SOF: ensure all fields in header are zero'd before copying back to userspace | From | Colin Ian King <> | Date | Wed, 22 Apr 2020 12:57:43 +0100 |
| |
On 22/04/2020 12:45, Dan Carpenter wrote: > On Wed, Apr 22, 2020 at 12:24:17PM +0100, Colin King wrote: >> From: Colin Ian King <colin.king@canonical.com> >> >> Field header.tlv is uninitialized and being copied back to userspace > ^^^^^^^^^^ > header.tlv is a zero element array so it doens't have any stack data.
Thanks Dan, I totally overlooked that. That's another class if issues I need to triage correctly.
> >> and hence leaking data from the stack to userspace. Fix this by >> ensuring the header structure is zero'd. > > regards, > dan carpenter > >
| |