lkml.org 
[lkml]   [2020]   [Apr]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RESEND PATCH v7 1/6] ACPI / APEI: Add support to queuing up the non-fatal HW errors and notify
On Tue, Apr 21, 2020 at 02:21:31PM +0100, Shiju Jose wrote:
> @@ -1346,6 +1467,12 @@ static int __init ghes_init(void)
> else
> pr_info(GHES_PFX "Failed to enable APEI firmware first mode.\n");
>
> + rc = ghes_gdata_pool_init();
> + if (rc) {
> + pr_warn(GHES_PFX "ghes_gdata_pool_init failed\n");
> + goto err;

There probably should be some clean up on this error path.

> + }
> +
> return 0;
> err:
> return rc;

regards,
dan carpenter

\
 
 \ /
  Last update: 2020-04-21 16:18    [W:0.065 / U:0.956 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site