Messages in this thread | | | Date | Tue, 21 Apr 2020 17:12:20 +0300 | From | Dan Carpenter <> | Subject | Re: [RESEND PATCH v7 1/6] ACPI / APEI: Add support to queuing up the non-fatal HW errors and notify |
| |
On Tue, Apr 21, 2020 at 02:21:31PM +0100, Shiju Jose wrote: > @@ -1346,6 +1467,12 @@ static int __init ghes_init(void) > else > pr_info(GHES_PFX "Failed to enable APEI firmware first mode.\n"); > > + rc = ghes_gdata_pool_init(); > + if (rc) { > + pr_warn(GHES_PFX "ghes_gdata_pool_init failed\n"); > + goto err;
There probably should be some clean up on this error path.
> + } > + > return 0; > err: > return rc;
regards, dan carpenter
| |