Messages in this thread | | | Subject | Re: [PATCH 1/2] i2c: slave-eeprom: initialize empty eeprom properly | From | Bjorn Ardo <> | Date | Tue, 21 Apr 2020 14:03:41 +0200 |
| |
On 4/20/20 10:53 PM, Wolfram Sang wrote:
> On Mon, Apr 20, 2020 at 03:31:46PM -0500, Patrick Williams wrote: >> On Mon, Apr 20, 2020 at 06:43:49PM +0200, Wolfram Sang wrote: >>> On Wed, Oct 02, 2019 at 08:20:53AM +0200, Bjorn Ardo wrote: >>>> Hi, >>>> >>>> >>>> I sent in another patch earlier that added support for specifying a file in >>>> devicetree to initilize the eeprom from, corresponding to the case of >>>> pre-flashed eeprom. Maybe these two patches should be merged so this >>>> initialization is only done if no file is specified? >>> Yes, I agree. >>> >> It looks like Bjorn's referenced patches are still unmerged also? > Yes, it might be easiest if he merges your patch (with attribution) into > the else branch of his fw-load patch. >
OK, so to summarize, I should update my patch to use device_property_read_string() instead and also init the memory to 0XFF if no file is present. And change name of the function to i2c_slave_init_eeprom_data.
I will look into that and let you know once I'm done.
/BA
| |