Messages in this thread | | | Subject | Re: [Intel-wired-lan] [PATCH 1/1] e1000e: Disable s0ix flow for X1 Carbon 7th | From | Kai-Heng Feng <> | Date | Tue, 21 Apr 2020 12:50:12 +0800 |
| |
Hi,
> On Apr 21, 2020, at 04:27, Brown, Aaron F <aaron.f.brown@intel.com> wrote: > >> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of Kai- >> Heng Feng >> Sent: Wednesday, March 18, 2020 10:26 PM >> To: Kirsher, Jeffrey T <jeffrey.t.kirsher@intel.com> >> Cc: open list:NETWORKING DRIVERS <netdev@vger.kernel.org>; Kai-Heng Feng >> <kai.heng.feng@canonical.com>; moderated list:INTEL ETHERNET DRIVERS >> <intel-wired-lan@lists.osuosl.org>; David S. Miller <davem@davemloft.net>; >> open list <linux-kernel@vger.kernel.org> >> Subject: [Intel-wired-lan] [PATCH 1/1] e1000e: Disable s0ix flow for X1 Carbon >> 7th >> >> The s0ix flow makes X1 Carbon 7th can only run S2Idle for only once. >> >> Temporarily disable it until Intel found a solution. >> >> Link: https://lists.osuosl.org/pipermail/intel-wired-lan/Week-of-Mon- >> 20200316/019222.html >> BugLink: https://bugs.launchpad.net/bugs/1865570 >> Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com> >> --- >> drivers/net/ethernet/intel/e1000e/netdev.c | 16 ++++++++++++++-- >> 1 file changed, 14 insertions(+), 2 deletions(-) > > I do not have access to the "X1 Carbon 7th" this patch targets, but from a regression perspective against a number of other e1000e based parts:
This patch can be superseded by "e1000e: bump up timeout to wait when ME un-configure ULP mode". So it's better to drop this patch in favor of a more generic solution.
Kai-Heng
> Tested-by: Aaron Brown <aaron.f.brown@intel.com>
| |