lkml.org 
[lkml]   [2020]   [Apr]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] net: ethernet: ixp4xx: Add error handling inixp4xx_eth_probe()
From
Date
Hi Jakub:

On 2020/4/13 2:35, Jakub Kicinski wrote:
> On Sun, 12 Apr 2020 17:27:28 +0800 Tang Bin wrote:
>> The function ixp4xx_eth_probe() does not perform sufficient error
>> checking after executing devm_ioremap_resource(),which can result
>> in crashes if a critical error path is encountered.
>>
> Please provide an appropriate Fixes: tag.

Thanks for your reply.

I don't know whether the commit message affect this patch's result. If so,

I think the commit message in v2 needs more clarification. As follows:

    The function ixp4xx_eth_probe() does not perform sufficient error
checking

after executing devm_ioremap_resource(), which can result in crashes if
a critical

error path is encountered.

    Fixes: f458ac479777 ("ARM/net: ixp4xx: Pass ethernet physical base
as resource").


I'm waiting for you reply actively.

Thanks,

Tang Bin



\
 
 \ /
  Last update: 2020-04-21 06:46    [W:0.081 / U:0.088 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site