Messages in this thread | | | Subject | Re: [PATCH v2 1/2] regmap: Simplify implementation of the regmap_read_poll_timeout() macro | From | Markus Elfring <> | Date | Mon, 20 Apr 2020 16:35:37 +0200 |
| |
… > +++ b/include/linux/regmap.h … > @@ -122,26 +123,10 @@ struct reg_sequence { > */ > #define regmap_read_poll_timeout(map, addr, val, cond, sleep_us, timeout_us) \ > ({ \ … > + int __ret, __tmp; \ > + __tmp = read_poll_timeout(regmap_read, __ret, __ret || (cond), \ > + sleep_us, timeout_us, false, (map), (addr), &(val)); \ > + __ret ?: __tmp; \ > })
* Would you like to delete double underscores from these variable names?
* I find another implementation detail suspicious. Should the parameters “sleep_us” and “timeout_us” be enclosed by additional parentheses (similar to four other macro arguments)?
* Can the tag “Fixes” be relevant also for such adjustments?
Regards, Markus
| |