Messages in this thread | | | From | Adam Thomson <> | Subject | RE: [RESEND PATCH v2 1/2] mfd: da9063: Fix revision handling to correctly select reg tables | Date | Mon, 20 Apr 2020 08:14:13 +0000 |
| |
On 20 April 2020 08:32, Lee Jones wrote:
> > > > > > > > + return -EINVAL; > > > > > > > > > > Do you want to fail silently here? > > > > > > > > Well an error message is printed in the calling code, so didn't feel like it > > > > was necessary to have additional debug here. Felt like bloat. > > > > > > As a user, I would prefer a more specific reason. > > > > > > Thus, I would provide an error message here and omit the generic one. > > > > I can update although I'll of course then need to do similar messages for the > > other error legs of this function. FWIW, as this is only being called once in > > the same file this error leg of code currently can never occur. > > As a tiny improvement, it's not a deal breaker. If it's too much > work, you can either submit a subsequent patch or omit it completely.
Taken care of in the v3 patch set I submitted Friday. Hopefully that covers everything. :)
| |