lkml.org 
[lkml]   [2020]   [Apr]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH 5/5] powerpc: Remove _ALIGN_UP(), _ALIGN_DOWN() and _ALIGN()
    On Mon, 20 Apr 2020 at 18:39, Christophe Leroy <christophe.leroy@c-s.fr> wrote:
    >
    > These three powerpc macros have been replaced by
    > equivalent generic macros and are not used anymore.
    >
    > Remove them.
    >
    > Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr>

    Reviewed-By: Joel Stanley <joel@jms.id.au>

    riscv has a copy of these too that could probably be removed:

    arch/riscv/include/asm/page.h:#define _ALIGN_UP(addr, size)
    (((addr)+((size)-1))&(~((size)-1)))
    arch/riscv/include/asm/page.h:#define _ALIGN(addr, size)
    _ALIGN_UP(addr, size)



    > ---
    > arch/powerpc/include/asm/page.h | 7 -------
    > 1 file changed, 7 deletions(-)
    >
    > diff --git a/arch/powerpc/include/asm/page.h b/arch/powerpc/include/asm/page.h
    > index 3ee8df0f66e0..a63fe6f3a0ff 100644
    > --- a/arch/powerpc/include/asm/page.h
    > +++ b/arch/powerpc/include/asm/page.h
    > @@ -249,13 +249,6 @@ static inline bool pfn_valid(unsigned long pfn)
    > #include <asm/page_32.h>
    > #endif
    >
    > -/* align addr on a size boundary - adjust address up/down if needed */
    > -#define _ALIGN_UP(addr, size) __ALIGN_KERNEL(addr, size)
    > -#define _ALIGN_DOWN(addr, size) ((addr)&(~((typeof(addr))(size)-1)))
    > -
    > -/* align addr on a size boundary - adjust address up if needed */
    > -#define _ALIGN(addr,size) _ALIGN_UP(addr,size)
    > -
    > /*
    > * Don't compare things with KERNELBASE or PAGE_OFFSET to test for
    > * "kernelness", use is_kernel_addr() - it should do what you want.
    > --
    > 2.25.0
    >

    \
     
     \ /
      Last update: 2020-04-21 03:05    [W:2.642 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site