Messages in this thread | | | Date | Tue, 21 Apr 2020 01:13:55 +0200 | From | Peter Zijlstra <> | Subject | Re: [PATCH 2/2] sched: Extract the task putting code from pick_next_task() |
| |
On Mon, Apr 20, 2020 at 11:55:21PM +0100, Valentin Schneider wrote:
> >> + finish_prev_task(rq, prev, rf); > > > > I'm not sure I like the name of this function. Perhaps > > "balance_and_put_prev_task()"? Something more in kind to what the function > > does. > > > > The 'finish' thing isn't too far from the truth; it's the last thing we > need to do with the prev task (in terms of sched bookkeeping, I mean) - > and in Chen's defence ISTR Peter suggested that name. > > Seeing as it's a "supercharged" put_prev_task(), I could live with the > marginally shorter "put_prev_task_balance()".
What Valentin said; it's the last put we do before picking a new task. Also, I don't like long names. That said, I'm open to short and appropriate suggestions.
| |