Messages in this thread | | | Date | Tue, 21 Apr 2020 00:10:03 +0200 | From | David Sterba <> | Subject | Re: [PATCH] btrfs: move enum btrfs_compression_type to the UAPI header |
| |
On Sun, Apr 19, 2020 at 12:14:32PM +0200, Eugene Syromiatnikov wrote: > It is passed in struct btrfs_ioctl_defrag_range_args.compress_type > to BTRFS_IOC_DEFRAG_RANGE, so it has to be a part of UAPI. > Also, rely on enum definition rules to get BTRFS_NR_COMPRESS_TYPES > value and mark it as non-ABI.
Adding the compression types makes sense for the UAPI, Qu has sent patch to move more code to the exported headers ("btrfs: move on-disk structure definitions to btrfs_tree.h"), including the compression type definition.
I'd prefer to move the code in a bigger chunk than one by one, unless it's breaking compilation.
| |