lkml.org 
[lkml]   [2020]   [Apr]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v3 2/2] remoteproc: Fix and restore the parenting hierarchy for vdev
    Date
    The commit 086d08725d34 ("remoteproc: create vdev subdevice with specific
    dma memory pool") has introduced a new vdev subdevice for each vdev
    declared in the firmware resource table and made it as the parent for the
    created virtio rpmsg devices instead of the previous remoteproc device.
    This changed the overall parenting hierarchy for the rpmsg devices, which
    were children of virtio devices, and does not allow the corresponding
    rpmsg drivers to retrieve the parent rproc device through the
    rproc_get_by_child() API.

    Fix this by restoring the remoteproc device as the parent. The new vdev
    subdevice can continue to inherit the DMA attributes from the remoteproc's
    parent device (actual platform device).

    Fixes: 086d08725d34 ("remoteproc: create vdev subdevice with specific dma memory pool")
    Signed-off-by: Suman Anna <s-anna@ti.com>
    Reviewed-by: Mathieu Poirier <mathieu.poirier@linaro.org>
    Acked-by: Arnaud Pouliquen <arnaud.pouliquen@st.com>
    ---
    v3: No changes
    v2: https://patchwork.kernel.org/patch/11447653/

    drivers/remoteproc/remoteproc_core.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/remoteproc/remoteproc_core.c b/drivers/remoteproc/remoteproc_core.c
    index e12a54e67588..be15aace9b3c 100644
    --- a/drivers/remoteproc/remoteproc_core.c
    +++ b/drivers/remoteproc/remoteproc_core.c
    @@ -517,7 +517,7 @@ static int rproc_handle_vdev(struct rproc *rproc, struct fw_rsc_vdev *rsc,

    /* Initialise vdev subdevice */
    snprintf(name, sizeof(name), "vdev%dbuffer", rvdev->index);
    - rvdev->dev.parent = rproc->dev.parent;
    + rvdev->dev.parent = &rproc->dev;
    rvdev->dev.dma_pfn_offset = rproc->dev.parent->dma_pfn_offset;
    rvdev->dev.release = rproc_rvdev_release;
    dev_set_name(&rvdev->dev, "%s#%s", dev_name(rvdev->dev.parent), name);
    --
    2.26.0
    \
     
     \ /
      Last update: 2020-04-20 18:08    [W:2.689 / U:0.648 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site