Messages in this thread | | | Date | Thu, 2 Apr 2020 11:31:08 -0700 | From | Kees Cook <> | Subject | Re: [PATCH] kbuild: mkcompile_h: Include $LD version in /proc/version |
| |
On Thu, Apr 02, 2020 at 11:22:02AM -0700, Nick Desaulniers wrote: > With Kees patch + Masahiro's diff applied: > $ cat /proc/version > Linux version 5.6.0-rc7-next-20200330+ (ndesaulniers@<hostname > scrubbed>) (clang version 11.0.0 (git@github.com:llvm/llvm-project.git > 6d71daed03ced011cd25f4e4f4122a368fdc757d), LLD 11.0.0 > (git@github.com:llvm/llvm-project.git > 6d71daed03ced011cd25f4e4f4122a368fdc757d)) #167 SMP Thu Apr 2 11:17:36 > PDT 2020 > > Reviewed-by: Nick Desaulniers <ndesaulniers@google.com> > Tested-by: Nick Desaulniers <ndesaulniers@google.com>
Awesome! Thanks for testing. :)
> We could actually use this in Android for a VTS test I've, uh, been > meaning to write. Also, LOL at scrubbing the "compatible with" part, > reminds me of user agent strings in the browser, which are god awful.
Heh, yeah. That's there because (actually, I think _you_ told me this when I asked during the ClangBuiltLinux summit) other tools scanned the LD version string for the binutils-specific bits. For this, since it's newly added to the kernel /proc/version, nothing is already expecting to find an LD string, and it looked super weird in there if I left it as-is. Hence, scrub!
-Kees
-- Kees Cook
| |