lkml.org 
[lkml]   [2020]   [Apr]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [GIT PULL] x86 cleanups for v5.7
On Thu, Apr 2, 2020 at 11:04 AM Borislav Petkov <bp@alien8.de> wrote:
>
> My only worry is that if we had that support, we would have to keep two
> versions of the facilities which use it - one with asm goto with outputs
> and one without.

That's why it took three years for me to merge the "unsafe_put_user()"
stuff. I only did it once other issues had made PeterZ and people
decide that "asm goto is a required feature" for some of the other
stuff (static branches, whatever).

Because when it comes to small details like "we can remove a test and
a branch", it generally isn't worth the code complexity to have two
different copies. Particularly with how messy uaccess.h was.

The reason I did the additional uaccess.h cleanups was exactly because
I think I can have a CONFIG_ASM_GOTO_OUTPUTS thing, and minimize the
differences the same way we minimize them with CC_SET/CC_OUT doe the
__GCC_ASM_FLAG_OUTPUTS__ compiler support flag.

I haven't actually sat down to _do_ it, though. I spent several hours
on the cleanups as a break from pulling stuff during the merge window,
but this _is_ my busy time..

Linus

\
 
 \ /
  Last update: 2020-04-02 20:14    [W:0.039 / U:0.252 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site